Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-258] Display UnitRewards and ItemRewards #496

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lotuuu
Copy link
Collaborator

@lotuuu lotuuu commented Jun 11, 2024

Depends on lambdaclass/mirra_backend#698
Closes #258

Motivation

Adds ItemRewards and UnitRewards to battle victory screen.

How has this been tested?

Run the backend with this pr and check that the first level displays an unit and an item.

@lotuuu lotuuu self-assigned this Jun 11, 2024
@lotuuu lotuuu added the Waiting on PR Use this tag to alert reviewers that this PR shouldn't be merged until another one is merged first label Jun 11, 2024
@lotuuu lotuuu marked this pull request as ready for review June 11, 2024 21:43
@lotuuu lotuuu changed the title [GH-258] Display Add UnitRewards and ItemRewards [GH-258] Display UnitRewards and ItemRewards Jun 11, 2024
@lotuuu lotuuu marked this pull request as draft June 12, 2024 20:29
@lotuuu lotuuu marked this pull request as ready for review June 12, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting on PR Use this tag to alert reviewers that this PR shouldn't be merged until another one is merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show unit's and item's level rewards on victory DYNAMICALLY
1 participant